Re: IFF_NOARP & broadcasting [2]

[kuznet@xxxxxxxxxxxxx]

Hello!

> Ok, but even in this case there is minor problem. And it lies in
> net/ethernet/eth.c - eth_header.

You have just made great discovery. :-)

It was big puzzle why people blame that they see packets with zero MAC,
sometimes. Apparently, this happens on the first packet, when hh cache
is still not created. :-)


> Please comment on this patch :) :

I am not sure that this is right. Protocols using neighbour cache
will work, but anothers will fail on NOARP devices.

It is safer just to reorder two ifs, checking for daddr!=NULL first.

Alexey