netdev
[Top] [All Lists]

Re: gred_dump (2.4.17): bad semantic and memory leak

To: hadi@xxxxxxxxxx (jamal)
Subject: Re: gred_dump (2.4.17): bad semantic and memory leak
From: kuznet@xxxxxxxxxxxxx
Date: Sat, 19 Jan 2002 22:53:59 +0300 (MSK)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <Pine.GSO.4.30.0201191421110.19496-100000@shell.cyberus.ca> from "jamal" at Jan 19, 2 10:45:00 pm
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> GRED insists that table->initd is non-zero to be completely configured.

No matter what gred insists on, it must not return error to dump.

And you say wrong thing about atomicity. gred may not work while being
configured, but it always has some _state_ and is able to show it to dump.

rtattr_failure happens only when there is no room in skb.

Please, return success and an information about current state of gred.

Alexey

<Prev in Thread] Current Thread [Next in Thread>