netdev
[Top] [All Lists]

Re: [PATCH] make rt_intern_hash() don't search yet another time on UP

To: gandalf@xxxxxxxxxxxxxx (Martin Josefsson)
Subject: Re: [PATCH] make rt_intern_hash() don't search yet another time on UP
From: kuznet@xxxxxxxxxxxxx
Date: Sat, 19 Jan 2002 22:22:18 +0300 (MSK)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.21.0201191938280.15524-100000@tux.rsn.bth.se> from "Martin Josefsson" at Jan 19, 2 10:15:06 pm
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> rt_intern_hash() isn't needed on UP AFAIK.

Did you notice that route_slow works with enabled softirqs?


> And it fixes what I think is a small bug on SMP. We dereference
> rt_hash_table[hash].chain
>
> -     rthp = &rt_hash_table[hash].chain;

It is not dereference.

Alexey

<Prev in Thread] Current Thread [Next in Thread>