Jay/Andi, (humm, better send to netdev as well 8) )
I'm thinking about moving p8022_connection to sk->protinfo and make
llc_connection_alloc become llc_sock_alloc, so that we can move some of the
functionality to the struct sock and pass struct socks to the upper layers,
in NetBEUI we have llc_handler in struct nb_link, humm, so a link in
NetBEUI would be associated with a struct sock in 802.2, humm, then it
demultiplexes into several struct socks for the NetBEUI sessions... care to
think about this one with me? The idea is to make the two protocols use
more of the infrastructure in Linux (tp_pinfo for NetBEUI, like spx does)
so that maintainance of both become more possible for other net stacks
hackers that will see more things in common with other net stacks, what do
you think? It may well make the PF_LLC code you're working on more
simpler... another goal for doing this is to use lock_sock/release_socks
and friends the locking mechanism for most of the two stacks.
If anybody is interested in how NetBEUI and 802.2 stacks development is
going on and are willing to help, the patches are here:
http://bazar.conectiva.com.br/~acme/patches/wip/netbeui+8022.patch.CURRENT
for 2.4.9, based on the stacks PROCOM has released over a year ago as GPL.
and
http://bazar.conectiva.com.br/~acme/patches/wip/samba_netbeui.patch.CURRENT
samba 2.0.6 based
- Arnaldo
----- Forwarded message from Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
-----
> Date: Fri, 21 Sep 2001 14:07:13 -0300
> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
> Subject: some questions about struct sock
> To: Andi Kleen <ak@xxxxxx>
> X-Url: http://advogato.org/person/acme
>
> Hi Andi,
>
> Some questions about struct sock handling, have I got it right that
> in TCP/IP a struct sock is shared by both the IP and TCP layers with IP
> using sk->protinfo and TCP using sk->tp_pinfo? I want to know if this is
> the right way to go as I want to do the same thing for 802.2 and NetBEUI,
> so that I use the same locking techniques in net/ipv4. To do that I'll move
> the p8022_connection in 802.2 to sk->protinfo and the struct nb_session and
> struct netbeui_sock (that now is in sk->protinfo) to sk->tp_pinfo), is this
> something that makes sense?
>
> Best Regards,
>
> - Arnaldo
|