netdev
[Top] [All Lists]

Re: [PATCH] ioctl SIOCGIFNETMASK: ip alias bug 2.4.9 and 2.2.19

To: kuznet@xxxxxxxxxxxxx
Subject: Re: [PATCH] ioctl SIOCGIFNETMASK: ip alias bug 2.4.9 and 2.2.19
From: Matthias Andree <matthias.andree@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 11 Sep 2001 18:39:28 +0200
Cc: matthias.andree@xxxxxx, alan@xxxxxxxxxxxxxxxxxxx, wietse@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <200109111522.TAA16406@ms2.inr.ac.ru>
Mail-followup-to: kuznet@xxxxxxxxxxxxx, alan@xxxxxxxxxxxxxxxxxxx, wietse@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
References: <20010910221448.E30149@emma1.emma.line.org> <200109111522.TAA16406@ms2.inr.ac.ru>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Mutt/1.3.22.1i
On Tue, 11 Sep 2001, kuznet@xxxxxxxxxxxxx wrote:

> A. No way to do the trick with SIOCSIF*.

Well, ioctl cannot configure IP aliases, however. Indeed, it may be
useful to change the patch to not touch the SIOCS* functions and
document that it only accesses the first one.

> B. The things does not become simpler when code does something random.
>    The things become simpler when code checks something explicitly,
>    otherwise you have to add comment: "Well, here we do this against
>    plain logic, but this does not matter because of this, this and this."

That's true, but I would not want to make SIOCGIFADDR behave differently
than SIOCGIFNETMASK, in that case, I'd rather have SIOCGIFCONF just
return the first address per interface name.

I will prepare a new patch as my time permits (unless, of course,
someone is faster).

-- 
Matthias Andree
Outlook (Express) users: press Ctrl+F3 for the full source code of this post.
begin  dont_click_this_virus.exe
end

<Prev in Thread] Current Thread [Next in Thread>