netdev
[Top] [All Lists]

Re: [Patch 1of2] IPv6 addrconf_forward_change() bug

To: usagi-users@xxxxxxxxxxxxxx, dlstevens@xxxxxxxxxx
Subject: Re: [Patch 1of2] IPv6 addrconf_forward_change() bug
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Wed, 29 Aug 2001 13:23:10 +0900
Cc: netdev@xxxxxxxxxxx
In-reply-to: <OF420CE0E5.D3DB8C83-ON88256AB6.0082BD93@boulder.ibm.com>
References: <OF420CE0E5.D3DB8C83-ON88256AB6.0082BD93@boulder.ibm.com>
Sender: owner-netdev@xxxxxxxxxxx
In article <OF420CE0E5.D3DB8C83-ON88256AB6.0082BD93@xxxxxxxxxxxxxxx> (at Tue, 
28 Aug 2001 16:56:37 -0700), "David Stevens" <dlstevens@xxxxxxxxxx> says:

>      Below is a patch that saves a pointer to in6_dev in ctl->extra1 and
> uses that as the argument to addrconf_forward_change(). The existing code

applied.  thanks.

> --- linux-2.4.9/net/ipv6/addrconf.c      Tue Aug  7 08:30:50 2001
> +++ linux-2.4.9NEW/net/ipv6/addrconf.c   Tue Aug 28 14:49:48 2001
> @@ -1836,11 +1836,7 @@
>           struct inet6_dev *idev = NULL;
> 
>           if (valp != &ipv6_devconf.forwarding) {
> -              struct net_device *dev = dev_get_by_index(ctl->ctl_name);
> -              if (dev) {
> -                   idev = in6_dev_get(dev);
> -                   dev_put(dev);
> -              }
> +              idev = (struct net_device *)ctl->extra1;
                                ~~~~~~~~~~~~
                                inet6_dev *
>                if (idev == NULL)
>                     return ret;
>           } else

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>