Re: conflicting alignment requirements

[kuznet@xxxxxxxxxxxxx]

Hello!

> I was recently asked to remove the get/put_unaligned code from my
> VLAN patch, which I did.  However, I don't want to now pay a
> performance penalty on Sparc, or whatever...

I am sorry, but your get/put_unligned were 16 bit, which is full non-sense. :-)

Anyway, even if you got 32 bit values, nobody suffers, including
even those arms which corrupt data on unaligned accesses.
802.1q is aligned to blue book and it has the same alignnment as IP.


> So, what are the drawbacks of using get/put_unaligned? 

It is prohibited for anything but IPX etc, which really need to get
unaligned values.

Alexey