netdev
[Top] [All Lists]

Re: missing icmp errors for udp packets

To: kuznet@xxxxxxxxxxxxx
Subject: Re: missing icmp errors for udp packets
From: Andi Kleen <ak@xxxxxx>
Date: Wed, 1 Aug 2001 17:07:42 +0200
Cc: Pekka Savola <pekkas@xxxxxxxxxx>, therapy@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, Dave Miller <davem@xxxxxxxxxx>, Andi Kleen <ak@xxxxxx>
In-reply-to: <200107311917.XAA10862@ms2.inr.ac.ru>; from kuznet@ms2.inr.ac.ru on Tue, Jul 31, 2001 at 09:17:55PM +0200
References: <Pine.LNX.4.33.0107312207040.20518-100000@netcore.fi> <200107311917.XAA10862@ms2.inr.ac.ru>
Sender: owner-netdev@xxxxxxxxxxx
[Sorry for the late answer; I'm still travelling]

On Tue, Jul 31, 2001 at 09:17:55PM +0200, kuznet@xxxxxxxxxxxxx wrote:
> Hello!
> 
> > What I meant (to say) is, for people who _want_ to limit pings too,
> 
> CBQ can do this in any way, which is possible to imagine.
> 
> In any case, I need to get some verdict from Andi and Dave to move
> in either way.
> 
> [ For Dave and Andi: should I resume the problem? ]

I think just turning the ratelimit sysctls into boolean that turn on/off
if the ICMP is checked against a single ratelimit per dst_entry would be 
fine. I thought about splitting it into informational and error, but do
not see a real benefit in it, it would also make configuration for the user
harder (he would need to find out to what type an ICMP belongs). And as 
you note for more complicated setups there is always CBQ. 

-Andi

<Prev in Thread] Current Thread [Next in Thread>