Re: missing icmp errors for udp packets

[kuznet@xxxxxxxxxxxxx]

Hello!

> So in conclusion:
> 
> with net.ipv4.icmp_echoreply_rate=0:

Congratulations! That's why I do not see this, forgot to ping before. :-)

The patch is enclosed.

Alexey


--- ../dust/vger3-010728/linux/net/ipv4/icmp.c  Thu Jun 14 22:49:44 2001
+++ linux/net/ipv4/icmp.c       Sun Jul 29 19:52:55 2001
@@ -240,12 +240,15 @@
 int xrlim_allow(struct dst_entry *dst, int timeout)
 {
        unsigned long now;
+       static int burst;
 
        now = jiffies;
        dst->rate_tokens += now - dst->rate_last;
        dst->rate_last = now;
-       if (dst->rate_tokens > XRLIM_BURST_FACTOR*timeout)
-               dst->rate_tokens = XRLIM_BURST_FACTOR*timeout;
+       if (burst < XRLIM_BURST_FACTOR*timeout)
+               burst = XRLIM_BURST_FACTOR*timeout;
+       if (dst->rate_tokens > burst)
+               dst->rate_tokens = burst;
        if (dst->rate_tokens >= timeout) {
                dst->rate_tokens -= timeout;
                return 1;