netdev
[Top] [All Lists]

Re: skb_pull, etc. panics.

To: Richard Guy Briggs <rgb@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: skb_pull, etc. panics.
From: Andi Kleen <ak@xxxxxx>
Date: Wed, 13 Jun 2001 03:21:26 +0200
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20010606141145.L31244@grendel.conscoop.ottawa.on.ca>; from rgb@conscoop.ottawa.on.ca on Wed, Jun 06, 2001 at 08:11:45PM +0200
References: <20010606141145.L31244@grendel.conscoop.ottawa.on.ca>
Sender: owner-netdev@xxxxxxxxxxx
On Wed, Jun 06, 2001 at 08:11:45PM +0200, Richard Guy Briggs wrote:
> Hi again,
> 
> If this is an FAQ, can someone point me to the reasons that skb_push()
> and skb_put() panic rather than dropping the skb and complaining in the
> log?
> 
> If not, why does it do that?

Because an overflow or underflow is always a bug in the code. If you're 
not sure if the skb has enough room you have to use *_expand_headroom and 
friends.


-Andi

-- 
Life would be so much easier if we could just look at the source code.

<Prev in Thread] Current Thread [Next in Thread>