Re: net packet queue scheduler, packet_type and proto handlers

[Andi Kleen <ak@xxxxxx>]

On Tue, Feb 20, 2001 at 01:30:08PM +0100, Krzysztof Halasa wrote:
> 
>         switch (skb->data[1]) {
> #ifdef CONFIG_INET
>                 case AX25_P_IP:

[...]

Ugh.

Looks like a bug in the AX25 layer.

> What do you think about this change? Does anything depend on the current
> behavior?


I think it's not nice to let the upper layer handle the retry in all cases,
although it's only needed in a few special cases. Using netif_rx for the
uncommon case of reexamining the packet is better, because you keep it out
of the fast path. I don't see the twice examining by taps as a problem, 
it doesn't break anything as far as I know.

-Andi

-- 
This is like TV. I don't like TV.