netdev
[Top] [All Lists]

Re: alignment issues on netif_rx

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: alignment issues on netif_rx
From: Ralf Baechle <ralf@xxxxxxxxxxx>
Date: Sat, 16 Dec 2000 12:51:46 +0100
Cc: kai@xxxxxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <200012151606.IAA20579@pizda.ninka.net>; from davem@redhat.com on Fri, Dec 15, 2000 at 08:06:21AM -0800
References: <Pine.LNX.4.10.10012151332190.32035-100000@chaos.thphy.uni-duesseldorf.de> <200012151606.IAA20579@pizda.ninka.net>
Sender: owner-netdev@xxxxxxxxxxx
On Fri, Dec 15, 2000 at 08:06:21AM -0800, David S. Miller wrote:

>    Question is: Is this the right way to handle this problem, or should
>    netif_rx be smarter and take unalignment skbs?
>    BTW: Would the above realigning make sense on other archs, too
>    (for performance reasons)?
> 
> No, the MIPS port must handle unaligned memory accesses traps
> in kernel mode and fix them up.  Every port is required to
> do this, these can happen anywhere in the networking.

We do handle them on MIPS - since ca. '95 or so ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>