Re: PATCH 2.4.0.9.2: export ethtool interface

[Andi Kleen <ak@xxxxxx>]

On Thu, Sep 21, 2000 at 02:12:25PM +0200, David S. Miller wrote:
>    From: Andi Kleen <ak@xxxxxx>
>    Date:   Thu, 21 Sep 2000 13:33:02 +0200
> 
>    There is (2.4.0test9pre2): 
> 
> Andi, mind taking a quick peek at net/socket.c:sock_ioctl() :-)

I hadn't expected such stupid code to survive in 2.4 @)

Looks rather wastefull. How about adding a inode or file flag for that ? 

Also I would propose to run dev->do_ioctl and probably other device
methods inside the BKL, they are not performance critical anyways and 
it is much safer.


-Andi

-- 
This is like TV. I don't like TV.