netdev
[Top] [All Lists]

Re: [patch] TCP throughput after 2.2.17-pre1

To: andrewm@xxxxxxxxxx
Subject: Re: [patch] TCP throughput after 2.2.17-pre1
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sun, 18 Jun 2000 07:26:13 -0700
Cc: netdev@xxxxxxxxxxx, alan@xxxxxxxxxx, kuznet@xxxxxxxxxxxxx
In-reply-to: <394CD00E.A02FEBBE@uow.edu.au> (message from Andrew Morton on Sun, 18 Jun 2000 23:35:10 +1000)
References: <394CD00E.A02FEBBE@uow.edu.au>
Sender: owner-netdev@xxxxxxxxxxx
   Date: Sun, 18 Jun 2000 23:35:10 +1000
   From: Andrew Morton <andrewm@xxxxxxxxxx>

   The problem is caused by this patch:

The change aparently came from Alexey to cure some
deadlock issues.

I just noticed the change today, and I also am skeptical
about it's correctness.

It I understand correctly, it's the simple issue about the
lack of distinction between a socket buffer allocation failing
because of going over the socket limits or a real kmalloc failure
of some sort.

Someone needs to sort this out correctly and I'd like to ask
Alan to back this out until a better fix is found.

Later,
David S. Miller
davem@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>