netdev
[Top] [All Lists]

Re: timers in net/ipv6

To: ak@xxxxxx (Andi Kleen)
Subject: Re: timers in net/ipv6
From: kuznet@xxxxxxxxxxxxx
Date: Thu, 8 Jun 2000 20:59:03 +0400 (MSK DST)
Cc: andrewm@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20000608014830.A10453@fred.muc.de> from "Andi Kleen" at Jun 8, 0 01:48:30 am
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> > We have already discussed this. It is not safe, certainly,
> > and needs refcounting.
> 
> What I think is a bigger problem is the unsafe use of the spinlock:
> nothing prevents a timer on the same CPU from bumping into the spinlock,
> causing a deadlock.

No dedalock, it causes reference to freed memory rather
than deadlock.

>                Hmm, probably the locks need to be split (list lock,
> frag queue lock protected with del_timer_async + refcount) or maybe even

Nothing but refcount on fq. It is very simple and convenient solution.

Andi, I have already asked you: may I change IPv4/v6 defragmenters?
I remember, you had some large patches for it.


> irq save spinlocks (costly) 

Why?!

Alexey

<Prev in Thread] Current Thread [Next in Thread>