netdev
[Top] [All Lists]

Re: [timers] net/core/*

To: andrewm@xxxxxxxxxx (Andrew Morton)
Subject: Re: [timers] net/core/*
From: kuznet@xxxxxxxxxxxxx
Date: Tue, 30 May 2000 21:07:47 +0400 (MSK DST)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <3933BD65.4E106F8@uow.edu.au> from "Andrew Morton" at May 30, 0 11:08:53 pm
Sender: owner-netdev@xxxxxxxxxxx
Hello!

>   ** Why bother deleting the timer in the timer handler?  It's gone!

It is plain mud. Delete it.


>   OK, we have one path by which __dst_free() can be called from process 
> context.
> 
>   I'm dazed and confused.

I do not understand, what confused you. __dst_free can be called
from any context.


>   I used del_timer_async().  Added REVIEWME.

It does reference counting.

Andrew, did you read my mails or you did not?


> whitehole_close()
> 
>   Racy.  Use del_timer_sync().

Accepted!

To resume: del_timer() is dst.c and this one are OK.
All the rest is crap.

Alexey

<Prev in Thread] Current Thread [Next in Thread>