netdev
[Top] [All Lists]

Re: tx_timeout and timer serialisation

To: kuznet@xxxxxxxxxxxxx, Andrew Morton <andrewm@xxxxxxxxxx>
Subject: Re: tx_timeout and timer serialisation
From: Andrey Savochkin <saw@xxxxxxxxxxxxx>
Date: Wed, 3 May 2000 10:45:26 +0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <200005021334.RAA14118@ms2.inr.ac.ru>; from "A.N.Kuznetsov" on Tue, May 02, 2000 at 05:34:33PM
References: <390E3143.5CF7D4AD@uow.edu.au> <200005021334.RAA14118@ms2.inr.ac.ru>
Sender: owner-netdev@xxxxxxxxxxx
Hello,

On Tue, May 02, 2000 at 05:34:33PM +0400, A.N.Kuznetsov wrote:
>
[snip]
> > speedo_timer does mdio_read()s.  speedo_tx_timeout() does mdio_read()s
> > and mdio_write()'s.  mdio functions are stateful.  Race.
> 
> Are they touched in normal rx/tx path and/or irq? If they are not,
> it is easy to repair with _separate_ mdio bh protected spinlock.
> 
> The problem can be with control registers, which are reprogrammed
> at IRQ level.

mdio functions are called only from timer handler, open, and ioctl.
They touch only MDIO specific control register, so they can be serialised by
BH protection.  I'll do it for eepro100 driver when I get some time.

Best regards
                                        Andrey V.
                                        Savochkin

<Prev in Thread] Current Thread [Next in Thread>