Re: ppp control frame passing (was: (none) / Re: your mail)

[kuznet@xxxxxxxxxxxxx]

Hello!

> Okay, yeah, now I remember... However, it's not true as long as the lock
> might be grabbed from (pppd) process context, right.
> have two options: Use spinlock_irqsave, which is always safe, or schedule
> a task from process context, so the lock will always be grabbed from BH. I
> think I prefer the latter.

Third option in 2.2 is plain start_bh_atomic().

> However, it's okay to grab dev->xmit_lock? I mean, is it kind of an
> exported interface?

Mmm... it is good and difficult question. 8)8)

Well, it exists, hence, you may use it. 8) Some tasks require to serialize
driver code wrt hard_start_xmit() (mainly, dev->ioctl()).
Actually, if it will want to disappear or to change its sense one day,
the fact that you use it and the way which you use it can be even useful
information. 8)

Alexey