Re: ppp control frame passing (was: (none) / Re: your mail)

[kuznet@xxxxxxxxxxxxx]

Hello!

> Just one more question, about backporting: spinlock_bh doesn't exist in
> 2.2 AFAICS, I guess I need to use spinlock_irqsave?

You need not any spinlock in 2.2.

In 2.2 all xmit path executes only on BH, it is single thread
and no more locks are required.

Yes, it is true provided it is never used from hard irq!
If it is, then you have to use irq protection in 2.3 as well.
Or better to queue a BH task.


>             netif_stop_queue();

It is better to avoid to use netif_stop_queue(dev) outside
of spin_lock_bh(&dev->xmit_lock). Most of devices sets it only
in hard_start_xmit(), where this lock is grabbed by caller.

If you submit frame internally, it is not bad idea to acquire
this lock. It is not necessary, but you will lose the property
that hard_start_xmit is not entered when device is throttled.
If it is not a problem for your device, then this is not required.

Alexey