Re: BUG: 2.3.35 SMP tcpdump crash

[kuznet@xxxxxxxxxxxxx]

Hello!

> I must be very stupid today.  skb_copy() still copies MAC header:
> 
>       /* Copy the bytes */
>       memcpy(n->head,skb->head,skb->end-skb->head);

Superb!

> If you mean skb_cow: why not revert my recent `fix'.  Something like
> this, and be happy 8-).

Well, actually I did _not_ want to copy it in skb_cow().
When head is reallocated, copying old head is useless work.

The thing, which I said about, is that potential users of
skb_expand _probably_ really want this, when they expand tail.

Alexey