netdev
[Top] [All Lists]

[PATCH 1/8] netpoll: rx_flags bugfix

To: Andrew Morton <akpm@xxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: [PATCH 1/8] netpoll: rx_flags bugfix
From: Matt Mackall <mpm@xxxxxxxxxxx>
Date: Thu, 11 Aug 2005 21:19:10 -0500
Cc: ak@xxxxxxx, Jeff Moyer <jmoyer@xxxxxxxxxx>, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, mingo@xxxxxxx, john.ronciak@xxxxxxxxx, rostedt@xxxxxxxxxxx
In-reply-to: <1.502409567@selenic.com>
Sender: netdev-bounce@xxxxxxxxxxx
Initialize npinfo->rx_flags.  The way it stands now, this will have random
garbage, and so will incur a locking penalty even when an rx_hook isn't
registered and we are not active in the netpoll polling code.

Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>

--- linux-2.6.12/net/core/netpoll.c.orig        2005-07-01 14:02:56.039174635 
-0400
+++ linux-2.6.12/net/core/netpoll.c     2005-07-01 14:03:16.688739508 -0400
@@ -639,6 +639,7 @@ int netpoll_setup(struct netpoll *np)
                if (!npinfo)
                        goto release;
 
+               npinfo->rx_flags = 0;
                npinfo->rx_np = NULL;
                npinfo->poll_lock = SPIN_LOCK_UNLOCKED;
                npinfo->poll_owner = -1;

<Prev in Thread] Current Thread [Next in Thread>