netdev
[Top] [All Lists]

Re: Oops - bug in IPv6 code

To: Netdev list <netdev@xxxxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, "David S . Miller" <davem@xxxxxxxxxx>, Pedro Roque <roque@xxxxxxxxxxx>, Linux Kernel List <linux-kernel@xxxxxxxxxxxxxxxx>
Subject: Re: Oops - bug in IPv6 code
From: <venaas@xxxxxxxxxxx>
Date: Sat, 27 Nov 1999 11:16:32 +0100
In-reply-to: <19991127103026.A6725@wiget>; from Artur Frysiak on Sat, Nov 27, 1999 at 10:30:26AM +0100
References: <19991127103026.A6725@wiget>
Sender: owner-netdev@xxxxxxxxxxx
On Sat, Nov 27, 1999 at 10:30:26AM +0100, Artur Frysiak wrote:
> Code;  c4823e83 <[ipv6]tcp_v6_err+2db/4b0>
> 00000000 <_EIP>:
> Code;  c4823e83 <[ipv6]tcp_v6_err+2db/4b0>   <=====
>    0:   86 46 34                  xchg   %al,0x34(%esi)   <=====
> Code;  c4823e86 <[ipv6]tcp_v6_err+2de/4b0>
>    3:   c0                        (bad)  
> Code;  c4823e87 <[ipv6]tcp_v6_err+2df/4b0>
>    4:   74 0a                     je     10 <_EIP+0x10> c4823e93 
> <[ipv6]tcp_v6_err+2eb/4b0>
> Code;  c4823e89 <[ipv6]tcp_v6_err+2e1/4b0>
>    6:   f7 d8                     neg    %eax
> Code;  c4823e8b <[ipv6]tcp_v6_err+2e3/4b0>
>    8:   89 83 54 02 00 00         mov    %eax,0x254(%ebx)
> Code;  c4823e91 <[ipv6]tcp_v6_err+2e9/4b0>
>    e:   eb 22                     jmp    32 <_EIP+0x32> c4823eb5 
> <[ipv6]tcp_v6_err+30d/4b0>
> Code;  c4823e93 <[ipv6]tcp_v6_err+2eb/4b0>
>   10:   46                        inc    %esi
> Code;  c4823e94 <[ipv6]tcp_v6_err+2ec/4b0>
>   11:   20 00                     and    %al,(%eax)

I think the following patch might fix it:

--- tcp_ipv6.c.orig     Thu Aug 26 02:29:53 1999
+++ tcp_ipv6.c  Sun Oct 31 00:59:31 1999
@@ -632,7 +632,6 @@
 
                if (dst == NULL) {
                        struct flowi fl;
-                       struct dst_entry *dst;
 
                        /* BUGGG_FUTURE: Again, it is not clear how
                           to handle rthdr case. Ignore this complexity

This will be fixed in the next 2.2 I hope.

Stig

-- 
Duct tape is like the force.  It has a light side, and a dark side, and
it holds the universe together ...
                -- Carl Zwanzig

<Prev in Thread] Current Thread [Next in Thread>