possible bug in net/core/pktgen.c (2.6.10 kernel)

[Robert Olsson <Robert.Olsson@xxxxxxxxxxx>]

Dave Peterson writes:

 > I found a piece of code that looks problematic in the 2.6.10 kernel.
 > The following code appears starting on line 746 in function inject()
 > of net/core/pktgen.c:
 >                                         schedule();
 >                                 else
 >                                         do_softirq();


 Thanks! 
 So it should be?

--- net/core/pktgen.c.orig      2005-01-16 13:39:10.933427120 +0100
+++ net/core/pktgen.c   2005-01-16 13:40:41.926751672 +0100
@@ -753,8 +753,11 @@
                                }
                                if (need_resched())
                                        schedule();
-                               else
+                               else {
+                                       preempt_disable();
                                        do_softirq();
+                                       preempt_enable();
+                               }
                        } while (netif_queue_stopped(odev));
                        idle = cycles() - idle_start;
                        info->idle_acc += idle;



                                                --ro