netdev
[Top] [All Lists]

Re: [benc@hawaga.org.uk: Linux "enable EUI-64 token format"]

To: Keith Owens <kaos@xxxxxxxxxx>
Subject: Re: [benc@hawaga.org.uk: Linux "enable EUI-64 token format"]
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 2 May 2001 21:20:15 -0700 (PDT)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <10031.988863372@kao2.melbourne.sgi.com>
References: <15088.56087.207394.585771@pizda.ninka.net> <10031.988863372@kao2.melbourne.sgi.com>
Sender: owner-netdev@xxxxxxxxxxx
Keith Owens writes:
 > On Wed, 2 May 2001 21:14:15 -0700 (PDT), 
 > "David S. Miller" <davem@xxxxxxxxxx> wrote:
 > >If the behavior is now going to be always EUI64=y and NO_PB=n, and
 > >we analyse the cpp if check:
 > 
 > CONFIG_IPV6_EUI64=y, CONFIG_IPV6_NO_PB=y is the correct configuration.

Then why are you deleting CONFIG_IPV6_NO_PB sections of code in other
parts of your patch, like this bit in net/ipv4/addrconf.c:

-#ifndef CONFIG_IPV6_NO_PB
-               if (pinfo->prefix_len == ((sizeof(struct in6_addr) - 
dev->addr_len)<<3)) {
-                       memcpy(&addr, &pinfo->prefix, plen);
-                       memcpy(addr.s6_addr + plen, dev->dev_addr,
-                              dev->addr_len);
-                       goto ok;
-               }
-#endif

This patch isn't even consistent.

Later,
David S. Miller
davem@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>