netdev
[Top] [All Lists]

Re: obvious ndisc.c bug

To: Ra Chen <Ra@xxxxxxxxxxxxxxxxxxx>
Subject: Re: obvious ndisc.c bug
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 19 Apr 2001 14:06:14 -0700 (PDT)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <92C0C0AC8AE8D411864300105A835CBB50A5B1@stslex.siemens.com.tw>
References: <92C0C0AC8AE8D411864300105A835CBB50A5B1@stslex.siemens.com.tw>
Sender: owner-netdev@xxxxxxxxxxx
Ra Chen writes:
 > net/ipv6/ndisc.c in kernel 2.4.3
 > line 1076:
 > 
 > if ((ipv6_addr_type(saddr)&IPV6_ADDR_MULTICAST) &&
 > 
 > "saddr" should be "daddr".

This code looks correct to me, what exactly makes you think it should
be testing "daddr"?  Similar code above for the solication cases also
checks "saddr" for being multicast.

Later,
David S. Miller
davem@xxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>