netdev
[Top] [All Lists]

Re: [RFT] simplify skge /proc interface.

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [RFT] simplify skge /proc interface.
From: Mirko Lindner <mlindner@xxxxxxxxxxxxx>
Date: 05 Sep 2008 11:26:04 +0200
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, Ralph Roesler <rroesler@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20030904160658.5ae22c0d.shemminger@osdl.org>
Organization:
References: <20030904160658.5ae22c0d.shemminger@osdl.org>
Sender: netdev-bounce@xxxxxxxxxxx
Thank you for the submission,

the latest driver version 6.17 (still by Linus) has a lot of
proc-changes. IÂll insert the remaining changes into our tree and make a
new release next week.

Cheers,

Mirko




On Fri, 2003-09-05 at 01:06, Stephen Hemminger wrote:
> This patch is against 2.6.0-test4 and simplifys the /proc interface for
> the skge driver.  
> 
> * Use seq_file single_open interface to avoid possible buffer over
>   run and formatting issues.
> * Put pointer to device in the proc dir private data to avoid having
>   to search through devices to find the info.
> * Use %lld rather than special formatting code
> * use proc_mkdir
> * Don't die if proc fs is not configured or creating entries fails.
> 
> New code is written in kernel style.
> 
> Builds and loads but don't have real hardware. Could someone
> please test this with a real board?
> 
> Somewhere in this 8K line driver is a 1000 line driver waiting to get out...
> 




<Prev in Thread] Current Thread [Next in Thread>