netdev
[Top] [All Lists]

Re: RFC: NAPI packet weighting patch

To: Martin Josefsson <gandalf@xxxxxxxxxxxxxx>
Subject: Re: RFC: NAPI packet weighting patch
From: jamal <hadi@xxxxxxxxxx>
Date: Tue, 07 Jun 2005 09:29:08 -0400
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, Mitch Williams <mitch.a.williams@xxxxxxxxx>, "Ronciak, John" <john.ronciak@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, mchan@xxxxxxxxxxxx, buytenh@xxxxxxxxxxxxxx, jdmason@xxxxxxxxxx, netdev@xxxxxxxxxxx, Robert.Olsson@xxxxxxxxxxx, "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, "Brandeburg, Jesse" <jesse.brandeburg@xxxxxxxxx>
In-reply-to: <Pine.LNX.4.58.0506071351080.16594@tux.rsn.bth.se>
Organization: unknown
References: <468F3FDA28AA87429AD807992E22D07E0450C00B@orsmsx408> <Pine.CYG.4.58.0506061647340.128@mawilli1-desk2.amr.corp.intel.com> <42A5284C.3060808@osdl.org> <1118147904.6320.108.camel@localhost.localdomain> <Pine.LNX.4.58.0506071351080.16594@tux.rsn.bth.se>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 2005-07-06 at 14:06 +0200, Martin Josefsson wrote:

> One thing that jumps to mind is that e1000 starts at lastrxdescriptor+1
> and loops and checks the status of each descriptor and stops when it finds
> a descriptor that isn't finished. Another way to do it is to read out the
> current position of the ring and loop from lastrxdescriptor+1 up to the
> current position. Scott Feldman implemented this for TX and there it
> increased performance somewhat (discussed here on netdev some months ago).
> I wonder if it could also decrease RX latency, I mean, we have to get the
> cache miss sometime anyway.
> 

The effect of Scotts patch was to reduce IO by amortizing it on the TX
side. Are we talking about the same thing ? This was in the case of TX
descriptor prunning? 
So it is possible that the e1000 is doing more than necessary share of
IO on the receive side as well.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>