netdev
[Top] [All Lists]

Re: RFC: NAPI packet weighting patch

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: RFC: NAPI packet weighting patch
From: jamal <hadi@xxxxxxxxxx>
Date: Fri, 27 May 2005 20:56:26 -0400
Cc: Mitch Williams <mitch.a.williams@xxxxxxxxx>, netdev@xxxxxxxxxxx, Robert.Olsson@xxxxxxxxxxx, "Ronciak, John" <john.ronciak@xxxxxxxxx>, "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, "Brandeburg, Jesse" <jesse.brandeburg@xxxxxxxxx>
In-reply-to: <20050527140132.1435132d@dxpl.pdx.osdl.net>
Organization: unknown
References: <Pine.CYG.4.58.0505261406210.2364@mawilli1-desk2.amr.corp.intel.com> <20050527085055.79da3d75@dxpl.pdx.osdl.net> <Pine.CYG.4.58.0505271305590.2148@mawilli1-desk2.amr.corp.intel.com> <20050527140132.1435132d@dxpl.pdx.osdl.net>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 2005-27-05 at 14:01 -0700, Stephen Hemminger wrote:

> 
> Why not just allow adjusting dev->weight via sysfs?

I think that should be good enough - and i thought your patch already
did this. 
Adding a shift to the weight in a _weighted_ RR algorithm does sound
odd.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>