netdev
[Top] [All Lists]

Re: Fw: 2.6.12-rc4-mm[12] - ULOG problem

To: Andrew Morton <akpm@xxxxxxxx>
Subject: Re: Fw: 2.6.12-rc4-mm[12] - ULOG problem
From: Evgeniy Polyakov <johnpol@xxxxxxxxxxx>
Date: Thu, 19 May 2005 11:27:19 +0400
Cc: herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx
In-reply-to: <20050519000809.2fca25c5.akpm@osdl.org>
Organization: MIPT
References: <20050518202458.55a63d37.akpm@osdl.org> <E1DYcyg-0005fP-00@gondolin.me.apana.org.au> <20050518222729.007887b8.akpm@osdl.org> <1116484313.21310.78.camel@uganda> <20050518234552.4aef6d02.akpm@osdl.org> <1116486385.21310.82.camel@uganda> <20050519000809.2fca25c5.akpm@osdl.org>
Reply-to: johnpol@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 2005-05-19 at 00:08 -0700, Andrew Morton wrote:
> Evgeniy Polyakov <johnpol@xxxxxxxxxxx> wrote:
> >
> >  > Is there any reason for being able to do that?
> > 
> >  It was created to be able to load several different connector devices 
> >  from different modules [basically it was module1.ko unit=10, module2.ko
> >  unit=11 and so on].
> 
> Loading multiple instances of the same module so that we get multiple
> instances of its data structures?   That's fairly ghastly.

It was not the same module.
it was quite different module which implemented similar functionality
and used different connector device for different purposes.

> We should remove the feature.  If there is demonstrated need for multiple
> instances then it should be done by more conventional means - syscall,
> allocation of a device major then use the minor as a selector or whatever.

It is easy to use feature which prevents problems
with situation when the same socket number is used, for example, 
in 2.6 kernel while connector uses it in -mm tree.

-- 
        Evgeniy Polyakov

Crash is better than data corruption -- Arthur Grabowski

Attachment: signature.asc
Description: This is a digitally signed message part

<Prev in Thread] Current Thread [Next in Thread>