Re: Perf data with recent tg3 patches

["Michael Chan" <mchan@xxxxxxxxxxxx>]

On Fri, 2005-05-13 at 17:50 -0700, David S.Miller wrote:

> Perhaps we can make the logic in tg3_poll() smarter about
> this.  Something like:
> 
>       tg3_process_phy_events();
>       tg3_tx();
>       tg3_rx();
> 
>       if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS)
>               tp->last_tag = sblk->status_tag;
>       rmb();
>       done = !tg3_has_work(tp);
>       if (done) {
>               spin_lock_irqsave(&tp->lock, flags);
>               __netif_rx_complete(netdev);
>               tg3_restart_ints(tp);
>               spin_unlock_irqrestore(&tp->lock, flags);
>       }
>       return (done ? 0 : 1);
> 
> Basically, move the last_tag sample to after we do the
> work, then recheck the RX/TX producer/consumer indexes.
> 

I like this. I think it will work well.