Re: [PATCH] netlink: defer socket destruction a bit

[Tommy Christensen <tommy.christensen@xxxxxxxxx>]

On Thu, 2005-05-12 at 01:03, Herbert Xu wrote:
> On Thu, May 12, 2005 at 12:35:06AM +0200, Tommy Christensen wrote:
> > 
> > No, skb2 cannot be shared with a listening socket. As I read the code,
> > it can only be non-null when delivery has failed.
> 
> What about this code path:
> 
> 1) skb2 = skb, refcnt++.
> 2) Devliered to socket 1.
> 3) Socket 1 frees skb through recvmsg.
> 4) skb2 = skb, refcnt++.
> 5) Delivery fails.
> 
> Now skb2 is identical to skb and they both refer to socket 1.

You're right, Herbert.  The interception by recvmsg has to be
considered in this case also.  Tricky.

I moved the call to skb_orphan in the other patch, as you
suggested.  I think that also makes this patch safe as it is.

Right?

-Tommy