netdev
[Top] [All Lists]

Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport clas

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport class
From: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
Date: Thu, 05 May 2005 07:45:47 -0400
Cc: YOSHIFUJI Hideaki / ???? <yoshfuji@xxxxxxxxxxxxxx>, michaelc@xxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <E1DTehn-0005gJ-00@gondolin.me.apana.org.au>
References: <E1DTehn-0005gJ-00@gondolin.me.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 2005-05-05 at 21:39 +1000, Herbert Xu wrote:
> YOSHIFUJI Hideaki / ???? <yoshfuji@xxxxxxxxxxxxxx> wrote:
> > In article <42798AC1.2010308@xxxxxxxxxxx> (at Wed, 04 May 2005 19:53:53 
> > -0700), Mike Christie <michaelc@xxxxxxxxxxx> says:
> > 
> >> +struct iscsi_uevent {
> > :
> >> +} __attribute__ ((aligned (sizeof(unsigned long))));
> > 
> > I think it'd be better to use sizeof(uint64_t) or something.
> 
> Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?


why align at all as opposed to just letting the compiler figure it out.




<Prev in Thread] Current Thread [Next in Thread>