Re: [2/4] [IPSEC] Kill spurious hard expire messages

[jamal <hadi@xxxxxxxxxx>]

Herbert,

On Sun, 2005-04-10 at 17:27, Herbert Xu wrote:

> 
> What I am saying is that this is impossible.  If it really bothers you
> we can turn the WARN_ON into a BUG.
> 

We started this discussion by asserting that an expire may be issued on
a policy (or state) despite a delete event notification already having
happened. Thats what we were/are trying to stop, no?
What i am saying is you are not stopping that with this:
---
  if (!xfrm_policy_delete(xp, dir))
        km_policy_expired(xp, dir, 1);
---

xfrm_policy_delete will return 0 whether the policy is dead or not.
OTOH, if it returns <0 for the case where it is dead, then an expire
event will not be issued. 

cheers,
jamal