netdev
[Top] [All Lists]

Re: [PATCH] RTNETLINK: Protocol family wildcard dumping for routing rule

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] RTNETLINK: Protocol family wildcard dumping for routing rules
From: jamal <hadi@xxxxxxxxxx>
Date: 07 Apr 2005 19:13:36 -0400
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <20050407223847.GX26731@postel.suug.ch>
Organization: jamalopolous
References: <20050407213838.GW26731@postel.suug.ch> <E1DJfBR-0007Ym-00@gondolin.me.apana.org.au> <20050407223847.GX26731@postel.suug.ch>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 2005-04-07 at 18:38, Thomas Graf wrote:
> -     [RTM_GETNEIGH - RTM_BASE] = { .dumpit = neigh_dump_info       }
> +     [RTM_GETNEIGH - RTM_BASE] = { .dumpit = neigh_dump_info       },
> +     [RTM_GETRULE  - RTM_BASE] = { .dumpit = rtnetlink_dump_all    },
>  };
>  

Shouldnt this just work (without this change) if you have
CONFIG_IP_MULTIPLE_TABLES?

If you want to be funky and have some default dumper always,
why not make the change to set dumpit to rtnetlink_dump_all in the code
when dumpit is found to be NULL as a last resort?

cheers,
jamal



<Prev in Thread] Current Thread [Next in Thread>