Re: take 2-2 WAS(Re: PATCH: IPSEC xfrm events

[jamal <hadi@xxxxxxxxxx>]

On Mon, 2005-04-04 at 09:02, Herbert Xu wrote:

> > -static struct list_head xfrm_km_list = LIST_HEAD_INIT(xfrm_km_list);
> > -static DEFINE_RWLOCK(xfrm_km_lock);
> 
> All I wanted was to leave these lines as is so that they didn't
> appear in the patch at all (except as conext) :)
>
> When reviewing patches the most annoying thing is to see things
> moved around or rearranged because that distracts the reviewer
> from the substantiative changes.

Ok, fair enough. It annoys me too when i review patches ;->
So i will fix this before final.

>  
> > ;-> Yes, indeed. I think its time for you to throw in the towel ;->
> 
> Alright I give in :)

Goody - now we can have Masahide run his full test.

cheers,
jamal