Re: take 2 WAS(Re: PATCH: IPSEC xfrm events

[jamal <hadi@xxxxxxxxxx>]

On Sun, 2005-04-03 at 11:47, Patrick McHardy wrote:

> >>+void km_state_notify(struct xfrm_state *x, struct km_event *c)
> >>+{
> >>+   struct xfrm_mgr *km;
> >>+   read_lock(&xfrm_km_lock);
> >>+   list_for_each_entry(km, &xfrm_km_list, list)
> >>+           km->notify(x, c);
> >>+   read_unlock(&xfrm_km_lock);
> >>+}
> 
> You call these functions from both softirq- and user-context, so you
> need to protect against BHs.
> 

You are absolutely correct. Thanks for catching this. 

cheers,
jamal