Re: RFC: IPSEC patch 0 for netlink events

[jamal <hadi@xxxxxxxxxx>]

Herbert,

On Tue, 2005-03-29 at 19:49, Herbert Xu wrote:
> Hi Jamal:
> 
> On Sun, Mar 27, 2005 at 02:07:29PM -0500, jamal wrote:
> >

> > +/* callback structure passed from either netlink or pfkey */
> > +struct xfrm_sa_cb
> > +{
> > +   u32     type; /* the type of caller netlink/pfkey/other */
> > +   u32     data; /* callee to caller */
> > +   void *hdr;
> > +   struct sk_buff *skb;
> 
> I don't think we need to carry the original hdr and skb around.

Any objection to still calling it (new name) struct xfrm_sa_cb but
with only one 32 bit value in it - namely data?
This way i could add any other thing in the future in it without
changing the function call paramaters.

cheers,
jamal