netdev
[Top] [All Lists]

Re: cls_u32 compile failure in current 2.6.12-rc1+BK tree

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: cls_u32 compile failure in current 2.6.12-rc1+BK tree
From: jamal <hadi@xxxxxxxxxx>
Date: 28 Mar 2005 08:15:25 -0500
Cc: Meelis Roos <mroos@xxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <20050328125802.GZ3086@postel.suug.ch>
Organization: jamalopolous
References: <Pine.SOC.4.61.0503272249040.5086@math.ut.ee> <1111972035.1091.946.camel@jzny.localdomain> <Pine.SOC.4.61.0503281017060.21333@math.ut.ee> <1112012657.1089.1013.camel@jzny.localdomain> <20050328123801.GY3086@postel.suug.ch> <1112014261.1089.1018.camel@jzny.localdomain> <20050328125802.GZ3086@postel.suug.ch>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2005-03-28 at 07:58, Thomas Graf wrote:

> Not sure what you mean, I don't want any ifdefs or actions bits
> in the classifiers itself anymore. Everytime we dump the actions
> we must be able to also dump the statistics so I think we can
> safely move tcf_exts_dump_stats into tcf_exts_dump and hide all
> dumping in that single API.
> 

But you cant completely do this for u32 tcf_exts_dump_stats.
in the case of ACTION compiled in but someone using old API.
The code that Meelis just mention that compiler complained about. 
There was no problem with u32 and tcf_exts_dump - with that you can hide
all #ifedfs. 

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>