| To: | Thomas Graf <tgraf@xxxxxxx> |
|---|---|
| Subject: | Re: memory leak in net/sched/ipt.c? |
| From: | jamal <hadi@xxxxxxxxxx> |
| Date: | 23 Mar 2005 08:11:37 -0500 |
| Cc: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Yichen Xie <yxie@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, kaber@xxxxxxxxx |
| In-reply-to: | <20050323125516.GP3086@postel.suug.ch> |
| Organization: | jamalopolous |
| References: | <E1DE44X-0001QM-00@gondolin.me.apana.org.au> <1111581618.1088.72.camel@jzny.localdomain> <20050323125516.GP3086@postel.suug.ch> |
| Reply-to: | hadi@xxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 2005-03-23 at 07:55, Thomas Graf wrote: > * jamal <1111581618.1088.72.camel@xxxxxxxxxxxxxxxx> 2005-03-23 07:40 > > Just a small correction to patchlet: > > The second kfree should check for existence of t. > > t is either valid or NULL so it's not a problem, unless you want > to create janitor work of course. ;-> if t is null you still goto rtattr_failure I have seen people put little comments of "kfree will work if you pass it NULL" - are you saying such assumptions exist all over net/sched? didnt understand the janitor part. cheers, jamal |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: memory leak in net/sched/ipt.c?, Thomas Graf |
|---|---|
| Next by Date: | Re: memory leak in net/sched/ipt.c?, Thomas Graf |
| Previous by Thread: | Re: memory leak in net/sched/ipt.c?, Thomas Graf |
| Next by Thread: | Re: memory leak in net/sched/ipt.c?, Thomas Graf |
| Indexes: | [Date] [Thread] [Top] [All Lists] |