Re: [RFC][PATCH 1/3] netlink check sender

[Stephen Smalley <sds@xxxxxxxxxxxxxx>]

On Sat, 2005-02-12 at 04:02, Chris Wright wrote:
> ===== net/netlink/af_netlink.c 1.69 vs edited =====
> --- 1.69/net/netlink/af_netlink.c     2005-01-21 12:25:32 -08:00
> +++ edited/net/netlink/af_netlink.c   2005-02-11 18:05:59 -08:00
>  int netlink_sendskb(struct sock *sk, struct sk_buff *skb, int protocol)
>  {
>       struct netlink_opt *nlk;
> -     int len = skb->len;
> -
> +     int err, len = skb->len;
> +     
>       nlk = nlk_sk(sk);
> +
> +     printk("%s: %s(%d) send_check %p\n", __FUNCTION__, current->comm, 
> current->pid, nlk->check_sender);
> +     if (nlk->check_sender)
> +             if ((err = nlk->check_sender(skb))) {
> +                     netlink_detachskb(sk, skb);
> +                     return err;
> +             }
> +

printk() is a leftover from debugging, I assume.  
Why place the check_sender() call here vs. just replacing the existing
security_netlink_send() call in netlink_sendmsg() with this new call?
 
-- 
Stephen Smalley <sds@xxxxxxxxxxxxxx>
National Security Agency