netdev
[Top] [All Lists]

Re: patch: annoying u32 double listing

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: patch: annoying u32 double listing
From: jamal <hadi@xxxxxxxxxx>
Date: 07 Feb 2005 08:49:29 -0500
Cc: Patrick McHardy <kaber@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050206223646.239c0d77.davem@davemloft.net>
Organization: jamalopolous
References: <1107719343.1055.22.camel@jzny.localdomain> <42068EA2.6030507@trash.net> <1107727330.1053.44.camel@jzny.localdomain> <4206A58A.9050909@trash.net> <20050206223646.239c0d77.davem@davemloft.net>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
I believe the last patch is correct. I can explain the many patches ;->
Call it the excitement to fix it if you may.
Its a problem that has existed for many years and many users have
complained about it but noone has really zoned on the cause fatale.
The 90% of it was really the patch i posted which zoned on it - for
years theory was the fix was in tc(user space). 
Patricks reincarnation got it to 95% and his second one got it to 100%.
IMO: Push it in, let some user whine.

cheers,
jamal

On Mon, 2005-02-07 at 01:36, David S. Miller wrote:
> On Mon, 07 Feb 2005 00:17:30 +0100
> Patrick McHardy <kaber@xxxxxxxxx> wrote:
> 
> > jamal wrote:
> > 
> > >I should have caught that output missing divisor ;->
> > >Dave please apply Patricks version. Should probably apply cleanly on
> > >2.4.x as well.
> > >
> > My last patch has a similar problem, new hash tables added with
> > "u32 divisor .." are skipped while walking. This patch is better
> > tested and should be fine. Applies to 2.4 and 2.6.
> 
> After seeing 4+ revisions of the same bug fix on the same day,
> let's let this sink for another day to make sure it's really
> the final version :-)
> 


<Prev in Thread] Current Thread [Next in Thread>