Re: [patch 4/10] s390: network driver.

[jamal <hadi@xxxxxxxxxx>]

On Sun, 2005-01-30 at 19:09, jamal wrote:
> Tommy,
> 
> I wasnt sure why you did:
> 
> dev->qdisc = &noop_qdisc;
> 
> You should probably save the old qdisc in qdisc_sleeping instead
> and restore it on wakeup - otherwise you always end with default qdisc.
> check_carrier should probably just call dev_activate

meant dev_deactivate - watch them locks though ..

cheers,
jamal

>  which does all you
> wanted, no?
> 
> cheers,
> jamal