On Thu, 2005-01-27 at 17:10 -0800, David S. Miller wrote:
> On Fri, 28 Jan 2005 11:29:29 +1100
> Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>
> > No, let's just fix them all.
>
> In tree, yes. But leaving the NF_HOOK()/NF_HOOK_THRESH() compat
> macros in there for out-of-tree modules I feel is mandatory, it's
> a major API change.
I'm not so sure. The hook functions which are registered, sure (ie.
keep the calling convention the same). But do any external modules use
NF_HOOK()? That implies they're writing their own network stack for
some protocol, which I would expect to be uncommon.
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
|