| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [RFC 2.6.10 4/22] xfrm: Try to offload inbound xfrm_states |
| From: | David Dillow <dave@xxxxxxxxxxxxxx> |
| Date: | Sat, 22 Jan 2005 00:52:13 -0500 |
| Cc: | Netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <20050121145608.65ad2d48.davem@davemloft.net> |
| References: | <20041230035000.12@ori.thedillows.org> <20041230035000.13@ori.thedillows.org> <20050121145608.65ad2d48.davem@davemloft.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 2005-01-21 at 14:56 -0800, David S. Miller wrote: > On Thu, 30 Dec 2004 03:48:35 -0500 > David Dillow <dave@xxxxxxxxxxxxxx> wrote: > > > # This is a BitKeeper generated diff -Nru style patch. > > # > > # ChangeSet > > # 2004/12/30 00:33:11-05:00 dave@xxxxxxxxxxxxxx > > # Plumb in offloading of inbound xfrm_states. > > # > > # Signed-off-by: David Dillow <dave@xxxxxxxxxxxxxx> > > Hmmm, this seems to deadlock. xfrm_state_add() is invoked > with the RTNL semaphore already acquired. For example, via > xfrm_user.c:xfrm_add_sa() Are you sure? It worked just fine during testing, and I don't see where in the call chain from xfrm_netlink_rcv() to xfrm_state_add() the RTNL sema is taken. Perhaps you were thinking of xfrm_cfg_sem? -- David Dillow <dave@xxxxxxxxxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state, David Dillow |
|---|---|
| Next by Date: | Re: [RFC 2.6.10 5/22] xfrm: Attempt to offload bundled xfrm_states for outbound xfrms, David Dillow |
| Previous by Thread: | Re: [RFC 2.6.10 4/22] xfrm: Try to offload inbound xfrm_states, David S. Miller |
| Next by Thread: | Re: [RFC 2.6.10 4/22] xfrm: Try to offload inbound xfrm_states, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |