Re: path: module replay

[jamal <hadi@xxxxxxxxxx>]

On Tue, 2005-01-18 at 23:26, Patrick McHardy wrote:
> jamal wrote:
> 
> >Ok, here is the last patch. I think module replay should be done from
> >that spot and to be consistent as well from cls_api.c for legacy stuff.
> >I also fixed a module ref count leak. 
> >the act_api piece is dependent on what i sent earlier for namsiz.
> >the cls_api change i believe conflicts with what Thomas sent yesterday.
> >
> +replay:
>                 act = tcf_action_init_1(tb[i], est, name, ovr, bind, err);
> -               if (act == NULL)
> -                       goto err;
> +               if (act == NULL) {
> +                       if (*err == -EAGAIN)
> +                               goto replay;
> +                       goto err_out;
> +               }
> 
> This part is wrong. 

And we exchanged emails on this topic already in private and you said 
you will fix and send out the patch;-> So please do just that or you can
wait until i have more time and my hardware at the same spot.

cheers,
jamal