netdev
[Top] [All Lists]

Re: [PATCH 2/9] PKT_SCHED: tc filter extension API

To: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2/9] PKT_SCHED: tc filter extension API
From: jamal <hadi@xxxxxxxxxx>
Date: 31 Dec 2004 00:04:39 -0500
Cc: Patrick McHardy <kaber@xxxxxxxxx>, Thomas Graf <tgraf@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <41D4B3AD.9080605@conectiva.com.br>
Organization: jamalopolous
References: <20041230122652.GM32419@postel.suug.ch> <20041230123023.GO32419@postel.suug.ch> <41D4A4D2.4000109@trash.net> <41D4B3AD.9080605@conectiva.com.br>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 2004-12-30 at 21:04, Arnaldo Carvalho de Melo wrote:

> > 
> > Please use act == NULL
> 
> Agreed, but I understand the people who like this (ugly) style, it becomes
> less likely to become an "if (act = NULL)", but hey, compilers already
> helps us with a nice warning.

There are certain people who would kill you for doing the above ;->
Or maybe theyll just take away your coffee. I think its a taste issue.
Code looks fine either way. 

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>