netdev
[Top] [All Lists]

Re: [PATCH 3/9] PKT_SCHED: u32: make use of tcf_exts API

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH 3/9] PKT_SCHED: u32: make use of tcf_exts API
From: jamal <hadi@xxxxxxxxxx>
Date: 30 Dec 2004 23:43:21 -0500
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041230123108.GP32419@postel.suug.ch>
Organization: jamalopolous
References: <20041230122652.GM32419@postel.suug.ch> <20041230123108.GP32419@postel.suug.ch>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 2004-12-30 at 07:31, Thomas Graf wrote:

>  
> +static struct tcf_ext_map u32_ext_map = {
> +     .action = TCA_U32_ACT,
> +     .police = TCA_U32_POLICE
> +};

Repeated on all classifiers - perhaps a little macro magic in order? ;->

Generally rest all looking good - I need to stare some more at the route
and tcindex one but dont see any show stoppers off hand;

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>