netdev
[Top] [All Lists]

Re: LLTX and netif_stop_queue

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: LLTX and netif_stop_queue
From: jamal <hadi@xxxxxxxxxx>
Date: 19 Dec 2004 14:31:15 -0500
Cc: Roland Dreier <roland@xxxxxxxxxxx>, netdev@xxxxxxxxxxx, openib-general@xxxxxxxxxx
In-reply-to: <20041217214432.07b7b21e.davem@davemloft.net>
Organization: jamalopolous
References: <52llbwoaej.fsf@topspin.com> <20041217214432.07b7b21e.davem@davemloft.net>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 2004-12-18 at 00:44, David S. Miller wrote:

> Perhaps one way to fix this is to add a pointer to a spinlock to
> the netdev struct, and have hold that the upper level grab that
> when NETIF_F_LLTX when doing queue state checks.  Actually, that
> could end up being racy too.

How about releasing the qlock only when the LLTX transmit lock is
grabbed? That should bring it to par with what it was originally.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>