netdev
[Top] [All Lists]

Re: [2.6 patch] net/sched/: possible cleanups

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [2.6 patch] net/sched/: possible cleanups
From: jamal <hadi@xxxxxxxxxx>
Date: 15 Dec 2004 09:03:12 -0500
Cc: Adrian Bunk <bunk@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041215112741.GJ8493@postel.suug.ch>
Organization: jamalopolous
References: <20041215012754.GH12937@stusta.de> <20041215112741.GJ8493@postel.suug.ch>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
This is fine. The new architecture doesnt require classifiers explicitly
call those function. Rest also looks fine to me. Good effort Adrian.

cheers,
jamal

On Wed, 2004-12-15 at 06:27, Thomas Graf wrote:
> * Adrian Bunk <20041215012754.GH12937@xxxxxxxxx> 2004-12-15 02:27
> 
> > -extern int tcf_act_police_locate(struct rtattr *rta, struct rtattr 
> > *est,struct tc_action *,int , int );
> > -extern int tcf_act_police_dump(struct sk_buff *, struct tc_action *, int, 
> > int);
> > -extern int tcf_act_police(struct sk_buff **skb, struct tc_action *a);
> 
> This looks like a police compat API for action policers but I think it's
> fine, Jamal?
> 
> The other changes all make sense to me.
> 


<Prev in Thread] Current Thread [Next in Thread>