On Thu, 2004-11-04 at 10:28, Patrick McHardy wrote:
> jamal wrote:
> >Please dont.
> >
> Ok, here is the same patch without removing tc_lookup_action_id.
> It is instead surrounded by #if 0.
Why is this function bothering you? ;->
Why do you need to put the #if 0?
> >I am incrementally submitting patches.
> >
> I was about to do more cleanup, please stop me if you are already doing
> any of this:
>
My changes will be new stuff going in. So any cleanup is welcome.
> - move the functions from include/net/pkt_act.h to act_generic.c
Some of the larger ones make sense to move. Whats the main reason for
moving them?
> - convert lastuse/install/expires to USER_HZ
> - fix ipt: leaks memory at destruction, ovr doesn't work, doesn't refcount
> iptables module references
>
These two make sense. I need help eyeballing the iptables stuff.
I commented out some of the refcount attempts; also i think quiet a
few targets are not friendly in getting accessed by anything other than
iptables; I was going at some point fix them and send you guys patches.
Maybe you can help me in this area as well.
> Is there already userspace-code for anything besides gact ?
> I would like to test my changes.
>
Stephen is probably stalled somewhere because he hasnt been sucking in
my updates to iproute2.
I have the latest and greatest on my test machine at home. But here
are tc updates for ipt and mirred that i could find on my laptop.
The ipt patch needs iptables libraries and may not work with latest
iptables (although the one at home will surely work). The problem is
some of the iptables functions were updated. It would be nice if i didnt
have to maintain my own variants in user space.
cheers,
jamal
tc-269-mirred-patch-oct052004
Description: Text document
patch-ipt-tc-269-3
Description: Text document
|